[ FIXED ] MacroCommand.execute() does not execute subCommands in FIFO order

[chphilli]

The MacroCommand.execute() method does not execute it's subCommands in FIFO order. Instead it executes them in LIFO order, due to the self.subCommands.pop() call. According to Python's documentation:

>>> help(list.pop)
Help on method_descriptor:

pop(...)
    L.pop([index]) -> item -- remove and return item at index (default last)

Changing the .pop() to .pop(0) causes the commands to be removed from the front of the list, providing FIFO ordering.

----

As a side question, I ran into this bug fairly early (In fact, I was writing a StartupCommand for my new application) -- how is it that other people haven't run into this problem?

[puremvc]

Good catch!

I personally don't use PHP or I'm sure I would've noticed this. I suspect that no one ever set up commands whose order actually mattered. Although the standard procedure is to prep the model before the view, if none of the view preparations lead immediately to requests for proxies that should've been registered already, you'd not notice the difference.

-=Cliff>

[chphilli]

Hi Cliff --

Thanks for the response -- just FYI, this is for the Python port, not the PHP port.

Is there anything more I should do to get this fixed?

[puremvc]

Sorry about that. Yes, email Toby, and point him to this thread just in case he hasn't seen it yet. You'll find a link to his profile and email on the Python port page.

Thanks
-=Cliff>

[tobydeh]

Hi Chris,

Sorry for the delay getting back to you...

Well spotted, I'll commit this change to the repository asap.

Toby.