Futurescale, Inc. PureMVC Home

The PureMVC Framework Code at the Speed of Thought


Welcome, Guest. Please login or register.
November 20, 2017, 03:53:12 PM
Home Help Search Login Register
News: Please DM @puremvc on Twitter to gain forum access. Spambots are why we can't have nice things.
Pages: [1]
Print
Author Topic: onRemove NEVER called  (Read 4232 times)
jason
Jr. Member
**
Posts: 13


View Profile
« on: July 11, 2011, 11:17:39 PM »

the basic java port of puremvc has been around for years.
Has nobody else noticed that Proxy core Mdel never calls onRemove when proxies are removed?
Same is true of both the Single and MultiCore versions.


Logged
puremvc
Global Moderator
Hero Member
*****
Posts: 2871



View Profile WWW
« Reply #1 on: July 12, 2011, 08:48:51 AM »

Alright, not good.

The Standard port has had quite a history, donated by one group, maintained for awhile by another curator and then replaced with a version that was made from the MultiCore port which handled things a little differently, but had many more eyes upon it.

Obviously going to need to get this fixed.

Thanks,
-=Cliff>
Logged
Tekool
Sr. Member
****
Posts: 192


View Profile WWW
« Reply #2 on: July 12, 2011, 01:18:29 PM »

Cliff, this is something I remember to have fixed in the singlecore version I've made. As I added Unit Tests this is something I can't have omitted.
Logged
Tekool
Sr. Member
****
Posts: 192


View Profile WWW
« Reply #3 on: July 12, 2011, 03:12:24 PM »

But I have  Cheesy

This is right the onRemove method is not called for the proxy : http://trac.puremvc.org/PureMVC_Java/browser/tags/1.0/src/org/puremvc/java/core/Model.java

I don't understand how the tests have passed. I do not have time right now but it needs some attention as http://trac.puremvc.org/PureMVC_Java_UnitTests/browser/tags/UnitTests_1_0/src/org/puremvc/java/core/ModelTestProxy.java is designed to test this.

Sorry not to have seen this during the upgrade I made on the standard port.

Logged
jason
Jr. Member
**
Posts: 13


View Profile
« Reply #4 on: July 12, 2011, 05:46:57 PM »

Quote from: Tek link=topic=1921.msg8562#msg8562 date=1310508744

I don't understand how the tests have passed. I do not have time right now but it needs some attention as [url

right, I saw this test too, but double checked both versions to be sure I wasn't delirious.
The test look fine, so I guess they must not be executed, I didn't try it myself because the tests are inconveniently packaged in another download so I just looked over them online.
Logged
jason
Jr. Member
**
Posts: 13


View Profile
« Reply #5 on: July 12, 2011, 06:24:24 PM »

The fix is of course trivial, and I've fixed my copy, but I guess your build/test process may take some time to sort.
Cheers.
Logged
puremvc
Global Moderator
Hero Member
*****
Posts: 2871



View Profile WWW
« Reply #6 on: January 14, 2012, 11:21:30 AM »

This bug has been fixed in the Standard port version 1.1 (Thanks Frederic).

However, I see that it is still present in MultiCore. I will ping Anthony.

-=Cliff>
Logged
Pages: [1]
Print
Jump to: