Futurescale, Inc. PureMVC Home

The PureMVC Framework Code at the Speed of Thought


Over 10 years of community discussion and knowledge are maintained here as a read-only archive.

New discussions should be taken up in issues on the appropriate projects at https://github.com/PureMVC

Pages: [1]
Print
Author Topic: missing super() call in puremvc.patterns.command.MacroCommand.__init__  (Read 5500 times)
akruis
Newbie
*
Posts: 2


View Profile Email
« on: March 13, 2013, 09:32:12 »

Version:
https://github.com/PureMVC/puremvc-python-standard-framework
commit 942bec84220fbc601e8064104199881271ad54c9

Problem:
The constructor method puremvc.patterns.command.MacroCommand.__init__() does not call
super(MacroCommand,self).__init__().

This causes puremvc.patterns.observer.Notifier.__init__() not to be executed. As a consequence a new MacroCommand lacks the attribute "facade". This causes AttributeError exceptions later on, if one uses the method "sendNotification".

Here is a patch to fix this issue: https://github.com/akruis/puremvc-python-standard-framework/commit/6cc93cf4bf86995336198782f9ba73779c3c4434
Logged
puremvc
Global Moderator
Hero Member
*****
Posts: 2871



View Profile WWW Email
« Reply #1 on: March 13, 2013, 11:52:55 »

Can you make a pull request for this on the PureMVC repo?

This should clearly be folded in.
Cheers,
-=Cliff>
Logged
Pages: [1]
Print